Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): do not default to tracing mode in jobs execution #9004

Merged
merged 1 commit into from
Nov 9, 2024
Merged

chore(ci): do not default to tracing mode in jobs execution #9004

merged 1 commit into from
Nov 9, 2024

Conversation

gustavovalverde
Copy link
Member

Motivation

Some jobs are hard to analyze as some variables are showing their values by default (which in some cases is the full log), multiple times in a single step.

If we'd like to debug with tracing, we can re-run a job with debugging on.

Solution

  • Remove the shell option with -x in most of the integration testing jobs

Tests

  • Tests should pass in this PR

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use P-Medium ⚡ labels Nov 7, 2024
@gustavovalverde gustavovalverde self-assigned this Nov 7, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner November 7, 2024 15:04
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team November 7, 2024 15:04
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 7, 2024
arya2
arya2 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would we be temporarily reverting these changes when we want to re-run a test with debug info?

@mergify mergify bot merged commit f919da3 into main Nov 9, 2024
141 of 143 checks passed
@mergify mergify bot deleted the chore-reduce-ci-log branch November 9, 2024 00:03
@arya2 arya2 mentioned this pull request Nov 15, 2024
Merged
6 tasks
@arya2 arya2 mentioned this pull request Dec 5, 2024
Merged
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavovalverde @arya2